ssossossosso

Forums

Covering OroCRM topics, including community updates and company announcements.  Subscribe

This topic contains 1 reply, has 2 voices, and was last updated by ishakuta ishakuta 4 years ago.

  • Creator
    Topic
  • #646
    alanstorm
    alanstorm
    Participant

    The handleResponse method of the Backbone app controller in

    vendor/oro/platform/src/Oro/Bundle/NavigationBundle/Resources/public/js/hash.navigation.js

    doesn’t deal well with non-well-formed HTML. Specifically, a javascript exception is thrown when the jQuery filter method encounters something like this

    $('Bad Text<div>...</div>').filter('#redirect').text();

    While this doesn’t appear to cause any errors in the current release, it does stop new developers from doing simple var_dump debugging up in the business logic section of the framework.

    I don’t know what the fix should be (jQuery migrate, using JSON in place of parsed HTML, some other parsing method, etc.), or if this extra content should be silently ignored or somehow displayed, but it would help adoption with junior developers or developers coming from less modern frameworks if dropping in the occasional var_dump or echo to debug something didn’t result in the soon to be dreaded Sorry, page was not loaded correctly error.

Viewing 1 replies (of 1 total)
  • Author
    Replies
  • #910
    ishakuta
    ishakuta
    Participant

    That already fixed, waiting beta 🙂

Viewing 1 replies (of 1 total)

You must be logged in to reply to this topic.