Translations not working for the Filter of choice-tree type

Hi Team,

I have issue in translations for filters which are of type = choice-tree . All other filters used in this example are of type string which are working fine with translations for {All} to {Tous}.But in filters used which are of type choice tree i am unable to see translations & it shows All instead of Tous.

Please find below screenshot:

Here you can notice that all starting 4 filters (type = String) have translations working fine for All as Tous but for last two filters(type = choice-tree) i.e for Associe a(owner) & DPR (businessUnitId) the translation for All is showing as All itself which is an issue.

Please find below the filter code used in datagrid for the above filters shown in screenshot :

YAML

filters: columns: name: type: string data_name: a.name clientnumber: type: number data_name: a.clientnumber dealernumber: type: string data_name: a.dealernumber agentcode: type: string data_name: a.agentcode owner: type: choice-tree label: oro.user.owner.label data_name: a.owner options: data: @oro_user.provider.filter.user_choice_tree->getList businessUnitId: label: oro.business_unit.label type: choice-business-unit data_name: a.owner options: data: @oro_organization.provider.filter.busines_unit_choice_tree->getList

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27

filters:             columns:                 name:                     type:      string                     data_name: a.name                   clientnumber:                     type: number                     data_name: a.clientnumber                 dealernumber:                     type:  string                     data_name:  a.dealernumber                 agentcode:                     type:  string                     data_name:  a.agentcode                 owner:                     type: choice-tree                     label: oro.user.owner.label                     data_name: a.owner                     options:                         data: @oro_user.provider.filter.user_choice_tree->getList                 businessUnitId:                     label: oro.business_unit.label                     type: choice-business-unit                     data_name: a.owner                     options:                         data: @oro_organization.provider.filter.busines_unit_choice_tree->getList

Kindly need help in suggestions on how to solve this Translation issue.

We have already added the key and value in oro_translations table(Key=All, Value=Tous). Inspite of that I am not able to see the translation.

Thanks & Regards,
Shreyas S

Topic

[Mike KudelyaParticipant]

Hi,

We will include the fix in the upcoming release.

As a temporary solution I can offer:

Create custom filter src/Custom/Bundle/FilterBundle/Resources/public/js/filter/choice-tree-filter.js:

JavaScript

define(function(require) { 'use strict'; var CustomChoiceTreeFilter; var _ = require('underscore'); var __ = require('orotranslation/js/translator'); var ChoiceTreeFilter = require('oro/filter/choice-tree-filter'); var tools = require('oroui/js/tools'); CustomChoiceTreeFilter = ChoiceTreeFilter.extend({ emptyValue: { type: 1, value: __('All') }, initialize: function() { CustomChoiceTreeFilter.__super__.initialize.apply(this, arguments); }, /** * @inheritDoc */ _getCriteriaHint: function() { var self = this; var value = (arguments.length > 0) ? this._getDisplayValue(arguments[0]) : this._getDisplayValue(); var option = null; if (!value.value) { return this.placeholder; } var values = value.value.split(','); var label = []; for (var i in values) { if (values[i] === __('All')) { label.push(values[i]); } else { for (var j in self.data) { if (parseInt(values[i]) === this.data[j].id) { label.push(this.data[j].name); } } } } var hintValue = this.wrapHintValue ? ('"' + label.join(',') + '"') : label.join(','); return (option ? option.label + ' ' : '') + hintValue; } }); return CustomChoiceTreeFilter; });

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52

define(function(require) {     'use strict';       var CustomChoiceTreeFilter;     var _ = require('underscore');     var __ = require('orotranslation/js/translator');     var ChoiceTreeFilter = require('oro/filter/choice-tree-filter');     var tools = require('oroui/js/tools');       CustomChoiceTreeFilter = ChoiceTreeFilter.extend({         emptyValue: {             type: 1,             value: __('All')         },           initialize: function() {             CustomChoiceTreeFilter.__super__.initialize.apply(this, arguments);         },           /**          * @inheritDoc          */         _getCriteriaHint: function() {             var self = this;             var value = (arguments.length > 0) ? this._getDisplayValue(arguments[0]) : this._getDisplayValue();             var option = null;               if (!value.value) {                 return this.placeholder;             }               var values = value.value.split(',');             var label = [];             for (var i in values) {                 if (values[i] === __('All')) {                     label.push(values[i]);                 } else {                     for (var j in self.data) {                         if (parseInt(values[i]) === this.data[j].id) {                             label.push(this.data[j].name);                         }                     }                 }             }               var hintValue = this.wrapHintValue ? ('"' + label.join(',') + '"') : label.join(',');             return (option ? option.label + ' ' : '') + hintValue;         }     });       return CustomChoiceTreeFilter; });

Register it on src/Custom/Bundle/FilterBundle/Resources/config/requirejs.yml:

YAML

config: map: '*': 'oro/filter/choice-tree-filter': 'customfilter/js/filter/choice-tree-filter' 'customfilter/js/filter/choice-tree-filter': 'oro/filter/choice-tree-filter': 'oro/filter/choice-tree-filter' config: paths: 'customfilter/js/filter/choice-tree-filter': 'bundles/customfilter/js/filter/choice-tree-filter.js'

1 2 3 4 5 6 7 8 9 10

config:     map:         '*':             'oro/filter/choice-tree-filter': 'customfilter/js/filter/choice-tree-filter'         'customfilter/js/filter/choice-tree-filter':             'oro/filter/choice-tree-filter': 'oro/filter/choice-tree-filter'   config:     paths:         'customfilter/js/filter/choice-tree-filter': 'bundles/customfilter/js/filter/choice-tree-filter.js'

I have created new post, where i explain how to create and extend bundle, if you need it.

[shreyasParticipant]

Hi Mike,

Thanks a lot for providing the fix. It resolved the issue.

Thanks & Regards,
Shreyas S

[Author]

Replies