ImportExportBundle how to make CollectionNormalizer working properly

My CSV look like this:

column1,column2,column3:item:id
text,text,1

In this case the collection (column3) is normally denormalized containing one item in collection.
How is it possible to import more than one item in collection ?

Something like this :

column1,column2,column3:item:id
text,text,1|3|4

Normalizer method looks like this:

public function denormalize($data, $class, $format = null, array $context = array())
{
if (!is_array($data)) {
return new ArrayCollection();
}
$itemType = $this->getItemType($class);
if (!$itemType) {
return new ArrayCollection($data);
}
$result = new ArrayCollection();
foreach ($data as $item) {
$result->add($this->serializer->denormalize($item, $itemType, $format, $context));
}
return $result;
}

Where :
$data = [‘item’ => [‘id’ => ‘1|3|4’]]
$item = [‘id’ => ‘1|3|4’]

What actually should look like this

$data = [[‘id’ => ‘1’],[‘id’ => ‘3’],[‘id’ => ‘4’]]

Should i use a custom DataConverter before deserialization ?

Topic

[Dima MakarukParticipant]

The DefaultDataConverter doesn’t check if the value should be an array:

protected function convertToComplexData(array $plainData, $skipNullValues = true) { $complexData = array(); foreach ($plainData as $compositeKey => $value) { if ($value !== null || !$skipNullValues) { $keys = explode($this->convertDelimiter, $compositeKey); $complexData = $this->setValueByKeys($complexData, $keys, $value); } } return $complexData; }

1 2 3 4 5 6 7 8 9 10 11 12 13

protected function convertToComplexData(array $plainData, $skipNullValues = true)     {         $complexData = array();         foreach ($plainData as $compositeKey => $value) {             if ($value !== null || !$skipNullValues) {                 $keys = explode($this->convertDelimiter, $compositeKey);                 $complexData = $this->setValueByKeys($complexData, $keys, $value);             }         }         return $complexData;     }

It look only if the key must be an array for further support of relations when deserializing.

[SergeyParticipant]

Hi, @dimonixx!

Please use TreeDataConverter to combine plain data into tree
https://github.com/orocrm/platform/blob/master/src/Oro/Bundle/IntegrationBundle/ImportExport/DataConverter/AbstractTreeDataConverter.php#L9

[Dima MakarukParticipant]

Hi thank you for the tip.
Somehow i’ve missed the TreeDataConverter class,will try to use it.

P.S.
I created additional normalizer for this case it worked.

[Author]

Replies