Dialog – strange behaviour

Hi,

I have two entities: listGroup and ListItem and in listGroup’s view i have a datagrid like this:

listitems-grid: options: toolbarOptions: pageSize: default_per_page: 50 extended_entity_name: %mekit_list.listitem.entity.class% source: type: orm acl_resource: mekit_list_view query: select: - li.id - li.label from: - { table: %mekit_list.listitem.entity.class%, alias: li } join: inner: - { join: li.listGroup, alias: lg } where: and: - lg.id = :entity_id bind_parameters: - entity_id columns: id: label: mekit.list.id.label label: label: mekit.list.label.label type: twig frontend_type: html template: MekitListBundle:Item:Datagrid/Property/editButton.html.twig

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33

listitems-grid:         options:             toolbarOptions:                 pageSize:                     default_per_page: 50         extended_entity_name: %mekit_list.listitem.entity.class%         source:             type:           orm             acl_resource:   mekit_list_view             query:                 select:                     - li.id                     - li.label                 from:                     - { table: %mekit_list.listitem.entity.class%, alias: li }                 join:                     inner:                         - { join: li.listGroup, alias: lg }                 where:                     and:                         - lg.id = :entity_id             bind_parameters:                 - entity_id           columns:             id:                 label:          mekit.list.id.label             label:                 label:          mekit.list.label.label                 type:           twig                 frontend_type:  html                 template:       MekitListBundle:Item:Datagrid/Property/editButton.html.twig

I have the editButton.html.twig:

{% import 'OroUIBundle::macros.html.twig' as UI %} {% if resource_granted('mekit_listitem_update') %} {% set updateListItemTitle = 'mekit.list.widgets.listitem_update'|trans %} {{ UI.clientLink({ 'dataUrl': path('mekit_listitem_update', { 'id': record.getValue('id') }), 'aCss': 'no-hash', 'iCss': 'icon-edit', 'dataId': record.getValue('id'), 'title' : updateListItemTitle, 'label' : value|trans, 'widget' : { 'type' : 'dialog', 'multiple' : false, 'reload-grid-name' : 'listitems-grid', 'options' : { 'alias': 'listitem_dialog', 'stateEnabled': true, 'dialogOptions' : { 'title' : updateListItemTitle, 'allowMaximize': false, 'allowMinimize': false, 'width': 600 } } } }) }} {% else %} {{- value|trans -}} {% endif %}

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30

{% import 'OroUIBundle::macros.html.twig' as UI %}   {% if resource_granted('mekit_listitem_update') %} {% set updateListItemTitle = 'mekit.list.widgets.listitem_update'|trans %} {{ UI.clientLink({ 'dataUrl': path('mekit_listitem_update', { 'id': record.getValue('id') }), 'aCss': 'no-hash', 'iCss': 'icon-edit', 'dataId': record.getValue('id'), 'title' : updateListItemTitle, 'label' : value|trans, 'widget' : { 'type' : 'dialog', 'multiple' : false, 'reload-grid-name' : 'listitems-grid', 'options' : { 'alias': 'listitem_dialog', 'stateEnabled': true, 'dialogOptions' : { 'title' : updateListItemTitle, 'allowMaximize': false, 'allowMinimize': false, 'width': 600 } } } }) }} {% else %} {{- value|trans -}} {% endif %}

which opens the ListItem’s edit form which has the following twig:

{% form_theme form with ['OroFormBundle:Form:fields.html.twig', _self] %} <div class="widget-content"> {% if saved %} <script type="text/javascript"> require(['underscore', 'orotranslation/js/translator', 'oroui/js/widget-manager', 'oroui/js/messenger', 'oroui/js/mediator'], function(_, __, widgetManager, messenger, mediator) { widgetManager.getWidgetInstance({{ app.request.get('_wid')|json_encode|raw }}, function(widget) { messenger.notificationFlashMessage('success', __('Item saved successfully')); mediator.trigger('widget_success:' + widget.getAlias()); mediator.trigger('widget_success:' + widget.getWid()); widget.remove(); }); }); </script> {% else %} {% if not form.vars.valid and form.vars.errors|length %} <div class="alert alert-error"> <div class="message"> {{ form_errors(form) }} </div> </div> {% endif %} <div class="form-container"> <form id="{{ form.vars.name }}" action="{{ formAction }}" method="post" class="listitem-form"> <fieldset class="form-horizontal"> {{ form_row(form.id) }} {{ form_row(form.label) }} {{ form_rest(form) }} <div class="widget-actions form-actions" style="display: none;"> <button class="btn" type="reset">{{ 'Cancel'|trans }}</button> <button class="btn btn-primary" type="submit">{{ 'Save'|trans }}</button> </div> </fieldset> </form> {{ oro_form_js_validation(form) }} </div> {% endif %} </div>

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39

{% form_theme form with ['OroFormBundle:Form:fields.html.twig', _self] %} <div class="widget-content"> {% if saved %} <script type="text/javascript"> require(['underscore', 'orotranslation/js/translator', 'oroui/js/widget-manager', 'oroui/js/messenger', 'oroui/js/mediator'], function(_, __, widgetManager, messenger, mediator) { widgetManager.getWidgetInstance({{ app.request.get('_wid')|json_encode|raw }}, function(widget) { messenger.notificationFlashMessage('success', __('Item saved successfully')); mediator.trigger('widget_success:' + widget.getAlias()); mediator.trigger('widget_success:' + widget.getWid()); widget.remove(); }); }); </script> {% else %} {% if not form.vars.valid and form.vars.errors|length %} <div class="alert alert-error"> <div class="message"> {{ form_errors(form) }} </div> </div> {% endif %} <div class="form-container"> <form id="{{ form.vars.name }}" action="{{ formAction }}" method="post" class="listitem-form"> <fieldset class="form-horizontal"> {{ form_row(form.id) }} {{ form_row(form.label) }} {{ form_rest(form) }} <div class="widget-actions form-actions" style="display: none;"> <button class="btn" type="reset">{{ 'Cancel'|trans }}</button> <button class="btn btn-primary" type="submit">{{ 'Save'|trans }}</button> </div> </fieldset> </form> {{ oro_form_js_validation(form) }} </div> {% endif %} </div>

Everything works fine except one strange thing – every time I edit a ListItem I see that the grid is being reloaded (/app_dev.php/datagrid/listitems-grid?listitems-grid%5Bentity_id%5D=2&listitems-grid%5B_pager%5D%5B_page%5D=1&listitems-grid%5B_pager%5D%5B_per_page%5D=10&listitems-grid%5B_parameters%5D%5Brefresh%5D=true) more and more times.
That is, by the time I edited 10 times I see that before the dialog diappeares, I see the reload actions triggered 10 times.

Can you check the code above to see if there is something strange?
thanks
a\

---

oro/platform(1.6.2) + oro/doctrine-extensions(1.0.7) + symfony/symfony(v2.3.27)

Topic

[SergeyParticipant]

Hi @jakabadambalazs!

'reload-grid-name' : 'listitems-grid'

1	'reload-grid-name' : 'listitems-grid'

this code refreshes grid on dialog action (for example: create entity dialog should refresh grid to make it appear on grid). Just remove it.

[jakabadambalazsParticipant]

Hi @Sergey,
Maybe my post wasn’t clear – I do want the listitems-grid to be refreshed (in fact if I remove the ‘reload-grid-name’ : ‘listitems-grid’ code it does not refresh).

However when I modify a grid item this refresh is triggered more and more times. That is, the first time I edit an item, when I hit the save button the refresh is triggered once. If I edit an item again and I hit save on the dialog, I see that the refresh is triggered twice. By the time I get to the 10th edit after hitting the save button – i get 10 consecutive refreshes.

I have actually resolved my problem by removing the alias:

'alias': 'listitem_dialog',

1	'alias': 'listitem_dialog',

because I had a hinch that there were many buttons (one per item) in the page with the same alias. By removing it now my problem is gone.
Is it ok to do this?

---

oro/platform(1.6.2) + oro/doctrine-extensions(1.0.7) + symfony/symfony(v2.3.27)

[Author]

Replies