Custom workflow condition action does not work

I try to create custom workflow transition action to implement message sending in AQ by STOMP.

I created my own new bundle Test\Bundle\STOMPBundle without any inheritance, added data to services.yml and wrote my action as full copy of assign_value action.

Test\Bundle\STOMPBundle\Resources\config\services.yml:

parameters: oro_workflow.action.send_stomp_message.class: Test\Bundle\STOMPBundle\Model\Action\SendSTOMPMessage services: oro_workflow.action.send_stomp_message: class: %oro_workflow.action.send_stomp_message.class% tags: - { name: oro_workflow.action, alias: send_stomp_message }

1 2 3 4 5 6 7 8 9 10

parameters:     oro_workflow.action.send_stomp_message.class: Test\Bundle\STOMPBundle\Model\Action\SendSTOMPMessage   services:     oro_workflow.action.send_stomp_message:         class: %oro_workflow.action.send_stomp_message.class%         tags:             - { name: oro_workflow.action, alias: send_stomp_message }

Test\Bundle\STOMPBundle\Model\Action\SendSTOMPMessage:

<?php namespace Test\Bundle\STOMPBundle\Model\Action; use Oro\Bundle\WorkflowBundle\Exception\InvalidParameterException; use Oro\Bundle\WorkflowBundle\Model\Action\AbstractAction; use Oro\Bundle\WorkflowBundle\Model\Condition\ConditionInterface; use Oro\Bundle\WorkflowBundle\Model\ContextAccessor; use Symfony\Component\PropertyAccess\PropertyPath; class SendSTOMPMessage extends AbstractAction { /** * @var array */ protected $assigns = array(); /** * {@inheritdoc} */ protected function executeAction($context) { foreach ($this->assigns as $assignOptions) { $this->contextAccessor->setValue( $context, $this->getAttribute($assignOptions), $this->getValue($assignOptions) ); } } /** * Get target. * * @param array $options * @return mixed */ protected function getAttribute(array $options) { return array_key_exists('attribute', $options) ? $options['attribute'] : $options[0]; } /** * Get value. * * @param array $options * @return mixed */ protected function getValue(array $options) { return array_key_exists('value', $options) ? $options['value'] : $options[1]; } /** * {@inheritdoc} */ public function initialize(array $options) { if ($this->isMassAssign($options)) { foreach ($options as $assignOptions) { $this->addAssign($assignOptions); } } else { $this->addAssign($options); } return $this; } /** * @param array $options * @throws InvalidParameterException */ protected function addAssign(array $options) { if (count($options) != 2) { throw new InvalidParameterException('Attribute and value parameters are required.'); } if (!isset($options['attribute']) && !isset($options[0])) { throw new InvalidParameterException('Attribute must be defined.'); } if (!array_key_exists('value', $options) && !array_key_exists(1, $options)) { throw new InvalidParameterException('Value must be defined.'); } if (!($this->getAttribute($options) instanceof PropertyPath)) { throw new InvalidParameterException('Attribute must be valid property definition.'); } $this->assigns[] = $options; } /** * @param array $options * @return bool */ protected function isMassAssign(array $options) { if (empty($options)) { return false; } foreach ($options as $element) { if (!is_array($element)) { return false; } } return true; } }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115

<?php   namespace Test\Bundle\STOMPBundle\Model\Action;   use Oro\Bundle\WorkflowBundle\Exception\InvalidParameterException; use Oro\Bundle\WorkflowBundle\Model\Action\AbstractAction;   use Oro\Bundle\WorkflowBundle\Model\Condition\ConditionInterface; use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;   use Symfony\Component\PropertyAccess\PropertyPath;   class SendSTOMPMessage extends AbstractAction {     /**      * @var array      */     protected $assigns = array();       /**      * {@inheritdoc}      */     protected function executeAction($context)     {         foreach ($this->assigns as $assignOptions) {             $this->contextAccessor->setValue(                 $context,                 $this->getAttribute($assignOptions),                 $this->getValue($assignOptions)             );         }     }       /**      * Get target.      *      * @param array $options      * @return mixed      */     protected function getAttribute(array $options)     {         return array_key_exists('attribute', $options) ? $options['attribute'] : $options[0];     }       /**      * Get value.      *      * @param array $options      * @return mixed      */     protected function getValue(array $options)     {         return array_key_exists('value', $options) ? $options['value'] : $options[1];     }       /**      * {@inheritdoc}      */     public function initialize(array $options)     {         if ($this->isMassAssign($options)) {             foreach ($options as $assignOptions) {                 $this->addAssign($assignOptions);             }         } else {             $this->addAssign($options);         }           return $this;     }       /**      * @param array $options      * @throws InvalidParameterException      */     protected function addAssign(array $options)     {         if (count($options) != 2) {             throw new InvalidParameterException('Attribute and value parameters are required.');         }           if (!isset($options['attribute']) && !isset($options[0])) {             throw new InvalidParameterException('Attribute must be defined.');         }         if (!array_key_exists('value', $options) && !array_key_exists(1, $options)) {             throw new InvalidParameterException('Value must be defined.');         }         if (!($this->getAttribute($options) instanceof PropertyPath)) {             throw new InvalidParameterException('Attribute must be valid property definition.');         }           $this->assigns[] = $options;     }       /**      * @param array $options      * @return bool      */     protected function isMassAssign(array $options)     {         if (empty($options)) {             return false;         }           foreach ($options as $element) {             if (!is_array($element)) {                 return false;             }         }           return true;     } }

Usage in workflow.yml (same as for assign_value action):

... post_actions: - @send_stomp_message: - [$probability, 0.5] ...

1 2 3 4 5 6 7

...                 post_actions:                     - @send_stomp_message:                         - [$probability, 0.5] ...

When I call my action I get error:

Catchable fatal error: Argument 1 passed to Oro\Bundle\WorkflowBundle\Model\Action\AbstractAction::__construct() must be an instance of Oro\Bundle\WorkflowBundle\Model\ContextAccessor, none given, called in /home/vagrant/orocrm/app/cache/dev/appDevDebugProjectContainer.php on line 16791 and defined in /home/vagrant/orocrm/vendor/oro/platform/src/Oro/Bundle/WorkflowBundle/Model/Action/AbstractAction.php on line 23

1 2 3

Catchable fatal error: Argument 1 passed to Oro\Bundle\WorkflowBundle\Model\Action\AbstractAction::__construct() must be an instance of Oro\Bundle\WorkflowBundle\Model\ContextAccessor, none given, called in /home/vagrant/orocrm/app/cache/dev/appDevDebugProjectContainer.php on line 16791 and defined in /home/vagrant/orocrm/vendor/oro/platform/src/Oro/Bundle/WorkflowBundle/Model/Action/AbstractAction.php on line 23

But when I replace my test action with original assign_value action everything is fine!

It seems that in input of my action all arguments put as null. What I do wrong? How I should declare my action in right way?

Topic

[Nikita PetrovParticipant]

Anybody please help me! :)

[Dmitry KhrysevMember]

Hi, Nikita

You have not added required ContextAccessor dependency to your service definition, that’s why you got this error

Catchable fatal error: Argument 1 passed to Oro\Bundle\WorkflowBundle\Model\Action\AbstractAction::__construct() must be an instance of Oro\Bundle\WorkflowBundle\Model\ContextAccessor, none given, called in /home/vagrant/orocrm/app/cache/dev/appDevDebugProjectContainer.php on line 16791 and defined in /home/vagrant/orocrm/vendor/oro/platform/src/Oro/Bundle/WorkflowBundle/Model/Action/AbstractAction.php on line 23

1 2 3

Catchable fatal error: Argument 1 passed to Oro\Bundle\WorkflowBundle\Model\Action\AbstractAction::__construct() must be an instance of Oro\Bundle\WorkflowBundle\Model\ContextAccessor, none given, called in /home/vagrant/orocrm/app/cache/dev/appDevDebugProjectContainer.php on line 16791 and defined in /home/vagrant/orocrm/vendor/oro/platform/src/Oro/Bundle/WorkflowBundle/Model/Action/AbstractAction.php on line 23

Correct service definition for your action must be

parameters: oro_workflow.action.send_stomp_message.class: Test\Bundle\STOMPBundle\Model\Action\SendSTOMPMessage services: oro_workflow.action.send_stomp_message: class: %oro_workflow.action.send_stomp_message.class% arguments: - @oro_workflow.context_accessor tags: - { name: oro_workflow.action, alias: send_stomp_message }

1 2 3 4 5 6 7 8 9 10 11 12

parameters:     oro_workflow.action.send_stomp_message.class: Test\Bundle\STOMPBundle\Model\Action\SendSTOMPMessage   services:     oro_workflow.action.send_stomp_message:         class: %oro_workflow.action.send_stomp_message.class%         arguments:             - @oro_workflow.context_accessor         tags:             - { name: oro_workflow.action, alias: send_stomp_message }

[Author]

Replies