ApiEntityManager->getOffset wrong

I wonder that how function getOffset works in tracksideoro\vendor\oro\platform\src\Oro\Bundle\SoapBundle\Entity\Manager\ApiEntityManager.php .

protected function getOffset($page)
{
if (!$page !== null) {
$page = $page > 0 ? $page – 1 : 0;
}

return $page;
}

It looks totally incorrect.

It should like this:

private function calculateOffset() {
//Calculet offset for items based on current page number
$this->offset = ($this->currentpage – 1) * $this->limit;
}

What do you think?

Regards,
Tom Nguyen

Topic

[Alexandr SmagaParticipant]

Hi. Yes it looks like a bug. Fix will be included in the nearest release.

Thank you!

[Author]

Replies