OneToMany relationship

Hello all,

I’m trying to implement a small app with OroPlatform and I have the following problem:
I have an entity ‘Person’ which is linked through a OneToMany relationship to an entity ‘SocialNetwork’, here are the annotations:

/** * @var Collection * * @ORM\OneToMany(targetEntity="MyBundle\Bundle\ContactBundle\Entity\SocialNetwork", mappedBy="owner", cascade={"all"}, orphanRemoval=true) * @ORM\OrderBy({"socialNetworkName" = "DESC"}) * @Soap\ComplexType("MyBundle\Bundle\ContactBundle\Entity\SocialNetwork[]", nillable=true) * @ConfigField( * defaultValues={ * "importexport"={ * "excluded"=true * } * } * ) */ protected $socialNetworks;

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17

/**      * @var Collection      *      * @ORM\OneToMany(targetEntity="MyBundle\Bundle\ContactBundle\Entity\SocialNetwork", mappedBy="owner", cascade={"all"}, orphanRemoval=true)      * @ORM\OrderBy({"socialNetworkName" = "DESC"})      * @Soap\ComplexType("MyBundle\Bundle\ContactBundle\Entity\SocialNetwork[]", nillable=true)      * @ConfigField(      *      defaultValues={      *          "importexport"={      *              "excluded"=true      *          }      *      }      * )      */     protected $socialNetworks;

I tried to do the same as the Contact entity and Address entity of the OroCRM bundle but whenever I try to post a form to create a new entity Contact without filling the social network fields I have the following error:

Argument 1 passed to ...\Person::addSocialNetwork() must be an instance of ...\SocialNetwork, null given

1 2 3

Argument 1 passed to ...\Person::addSocialNetwork() must be an instance of ...\SocialNetwork, null given

whereas it’s not a problem to leave the address fields empty in OroCRM while creating a new contact.
In a “classical” bundle I would normally set the default argument of addSocialNetwork to null but it doesn’t work (and it’s not used in OroCRM).
Am I missing something ?

Topic

[Yevhen ShyshkinParticipant]

Hello, Ximousse.

Probably, you should look at Oro\Bundle\FormBundle\Form\EventListener\CollectionTypeSubscriber::postSubmit – it checks collection for empty elements and remove them. Collection form type must be oro_collection or you can add this subscriber manually to your collection. Also to support this functionality your entity must implement interface Oro\Bundle\FormBundle\Entity\EmptyItem.

[XimousseParticipant]

Thank you Yevhen for your hint,
However I do have in my collection type:

public function getParent() { return 'oro_collection'; }

1 2 3 4 5 6

public function getParent()     {         return 'oro_collection';     }

and my Entity extends an abstract class with:

abstract class AbstractSocialNetwork implements EmptyItem {

1 2 3

abstract class AbstractSocialNetwork implements EmptyItem {

I’ll dig in the CollectionTypeSubscriber to try to find why it’s nor working for me.

[XimousseParticipant]

Ok, nevermind it was a simple cache problem so the EmptyItem works fine (and is extremely useful). Thanks!

[XimousseParticipant]

Ok I spoke too fast. I still have the problem:
In CollectionTypeSubscriber the following condition:

if ($item instanceof EmptyItem && $item->isEmpty()) {

1	if ($item instanceof EmptyItem && $item->isEmpty()) {

never gets fired because $item is null if I don’t fill at least one field of the entity in the OneToMany relationship.

[Yevhen ShyshkinParticipant]

Then you should check when and why null added to your collection – f.e. you can add breakpoint to add method. Probable reason – incorrect configuration of form type that should return only objects.

[XimousseParticipant]

I had the time to dig a bit into this, and I’m still a bit confused:
the problem I have comes from this: https://github.com/symfony/symfony/issues/9375
in vendor/symfony/symfony/src/Symfony/Component/Form/Extension/Core/Type/FormType.php

if (null !== $class) { return function (FormInterface $form) use ($class) { return $form->isEmpty() && !$form->isRequired() ? null : new $class(); }; }

1 2 3 4 5 6 7

if (null !== $class) {                 return function (FormInterface $form) use ($class) {                     return $form->isEmpty() && !$form->isRequired() ? null : new $class();                 };             }

thus, if I remove the required: false for my “SocialNetworkCollection” from my FormType I don’t have the problem anymore.
What bothers me is that the field is now marked as “required” (even though I can now leave it empty) and in OroCRM/ContactBundle/Form/Type/ContactType all the collections linked to the contact entity have the required option set to false.

[Yevhen ShyshkinParticipant]

Thank you for sharing your results!

If you still need to make field not required, you can pass custom “empty_data” option as empty instance of handled object.

[Author]

Replies